Fix vsix redirects #6416
Merged
Fix vsix redirects #6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
reviewed
Apr 2, 2019
| </AssemblyAttribute> | ||
| <AssemblyAttribute Include="Microsoft.VisualStudio.Shell.ProvideCodeBaseAttribute"> | ||
| <AssemblyName>FSharp.Compiler.Private</AssemblyName> | ||
| <Version>$(FSProductVersion)$(_BuildNumberSuffix)</Version> |
There was a problem hiding this comment.
Why the difference in assembly suffix? $(VSAssemblyVersion) vs $(FSProductVersion)$(_BuildNumberSuffix).
There was a problem hiding this comment.
VSAssemblyVersion is 15.9.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vsix was not correctly redirecting to all of the assemblies in the nightly vsix.
This change corrects a few assembly versions. And uses the project file mechanism to generate vsix bindingredirect and vsix codebase entries. And removed the hand coded incorrect ones.
Kevin